# AllTheThings

## [4.3.8](https://github.com/ATTWoWAddon/AllTheThings/tree/4.3.8) (2025-03-30)
[Full Changelog](https://github.com/ATTWoWAddon/AllTheThings/compare/4.3.7...4.3.8) [Previous Releases](https://github.com/ATTWoWAddon/AllTheThings/releases)

- parsing  
- Classic: Fixed a number of sync related bugs. Added a way to view the pending sync queue to /attsync. You can now delete sync targets to stop them from syncing once a sync has begun using this new UI.  
- Classic: Linked characters with the same name as a different character on another server should now correctly associate with the linked character from your current realm.  
- Fixed a bug with SetBatchCollected where it would always apply a new timestamp for the field when called despite having no new data to track. (thus making future syncs take longer than necessary)  
- added 5 fanfare choices  
- ci: deepen history for the main branch only  
    finally found a way to get non-shallow clone with tags through `actions/checkout`
  
    only for the work branch but that's exactly what we want  
- removed some temp .ogg file I had added in the past  
- Map Algari role achievement criterias per map rather than show the entire achievement in all maps  
- [Logic] Classic: Windows now use app.AddSlashCommands to add their custom commands  
- Updated retail build  
- Mark Tock the Clocker Spaniel as removed  
- [DB] Assigned a source for Wide World of Quests > Underlord Xerxiz criteria  
- [Logic] Re-factored the AddSlashCommands parameter order & migrated last Retail slash command handler to the Commands file  
- [Logic] Retail: Removed caching of the 'rwp' field [This is not necessary for any searching at this time and it breaks the Future Removed dynamic categories when in 'Simple' mode]  
- [DB] Retail: Harvested all Recipes/Reagents for 11.1  
- [Logic] Retail: Fixed Lua error when opening profession window  
- [Logic] Migrated most Chat command/link handling into a new Commands file  
- [Parser] Slight adjustment to the Uncollectible file such that Sourced items can be provided their 'non-collectible' state there such that it affects any Sourced versions of that Item in ATT  
    [DB] Fixed Living Branch and Feralas Ahi from showing as collectible  
- Update some FoS timelines, sort some items, fixes #1941  
- Update Vaean (n4228) post Cata coords (#1938)  
- New children's week achievement  
- New children's week achievement  
- [Logic] Retail: Migrated Debugger code to the existing Debugger window file  
- [Logic] Retail: Migrated a couple Event links  
- [Logic] Migrated & cleaned Fill logic into new Fill file  
- [Logic] Retail: Migrated Data handling/updating logic into a new DataHandling file  
- [Logic] Retail: Migrated RowOnEnter handler to Retail Window Logic  
- [Logic] Retail: Migrated app.TrySearchAHForGroup to Retail Window Logic  
- [Logic] Retail: Migrated RowOnLeave handler to Retail Window Logic  
- [Logic] Retail: Migrated C\_ContentTracking implementation to Retail Window Logic  
- [Logic] Retail: Moved RowOnClick handler to Retail Window Logic  
- [Logic] Retail: Migrated CreateMiniListForGroup to Retail Window Logic  
- Setup April2025 Trading Post  
- [DB] Splintered Spark of Dreams is no longer usable to create Spark of Dreams  
- Fix some reported quest and object errors  
- Add LoU skip quests, add undercoin purchasable gear  
- [DB] Retail: Fixed some data linkages and descriptions for 'Delegation' where handling differs from Cata Classic handling  
- [DB] Firelands: Only the Penitent  
- One more HAT for the HAT pile  
- Rework Slimy Cocoon listings, fix some reported errors, sort some HQTs  
- [DB] Fixed order of some Druid Artifact variants  
    [DB] 2 Rogue/Demon Hunter Off-hand Artifacts are not learnable (thanks Blizz???)  
    [Logic] Artifacts (re?)added to recalculate Account-wide data (I feel like they were there before and removed? But now seems to be working accurately as intended. Rip all of you who thought you had nearly 100% artifacts when you didn't actually)  
- [DB] Crafted Items/WotLK: Reinforced Crate  
- [Logic] Retail: Migrated more logic to Retail Window Logic  
- [DB] Few Zuldazar treasure updates  
- [Parser] Fixed Criteria not being removed when they are assigned an HQT and cloned to Sourced quests  
    [DB] Added source data for criteria 53446 in The World Beyond  
- [DB] Gallagio Garbage is daily and added note about loot not tied to daily lockout  
- [Logic] Retail: Filter selections can now be stored per-Profile (instead of per-Character) [This now allows players to maintain the same Appearance visibility across characters without needing to enable Account Mode to see all collectible Appearances, or need to toggle all Filters on every character]  
- [Logic] Retail: Cleaned up handling of Filter-based settings to prep for new storage option  
- [Logic] Moved direct references to AllTheThingsSettingsPerCharacter out of the Filters page  
- [Parser] Retail: Objective providers for NPC/Object will only be copied into the parent quest if the parent quest is deemed obtainable in the parse version  
- [Parser] Ignored Criteria which is assigned an HQT questID will now be marked as NYI so that a proper Source might be reported/determined when that Criteria is completed by users  
    [Logic] Added 'criteriaID' to caching logic so that Criteria don't consider themselves 'missing' and can be searched via chat command  
- Caverns of Time: Because we will never hear the end of it otherwise.  
- [DB] Re-added Trashmaster's Mantle from Vault +10 (anyone see one drop in M+??)  
- [Parser] More Criteria/Quest adjustments  
    * Adjusted Criteria/Quest logic when potentially merging into an NYI quest  
    * Ignored Criteria (not visible in WoW UI) which get assigned a HQT Quest no longer let themselves be ignored  
    [DB] Further removal of HQTs which are simply Criteria triggers  
- [Logic] Retail: Fixed 'Skyriding' showing up as a tracked thing when removing all tracking options  
- [Parser] Added a Debug Warn log message for when a Criteria is assigned a questID which is also Sourced under Unsorted (once existing cases are cleaned, will make it a normal warn log) ['assigned duplicated Unsorted Quest' -> 201]  
- [DB] Dragon Soul: Achievement descriptions and 9.2.5 vendor  
- [DB] Remnants in Caverns of Time  
- [Parser] Fixed a couple errors due to failed merges under HATs  
- [Logic] QuestID information type now includes an indication of completion (since questID can show up on groups which are collectible via other mechanisms, it's nice to also see the questID completion specifically)  
- [MISC] Note for Ravenous Slime to deal with later  
- [Logic] Retail: Migrated a bit more UI logic into the Retail Window Logic file  
- Fix many reported quest and object errors  
- Classic: Increased the number of reserved characters to 32 from 16 to account for the smaller chunk size when sending in non-bnet mode.  
- [DB] Commented remaining duplicated QuestID's which are now linked to the triggering Item  
- [DB] Commented/removed more HQT which are now automatically linked to Items [WIP]  
- Rebuild parser and reparse  
- Fix mrge conflict  
- Added a criteria type we don't want parser to throw out if it didn't come with incorporated data (when working without AchievementDB)  
- [Parser] Some fixes for Items which trigger Quests  
    * Fixed logic where Items would be assigned a questID from their trigger SpellEffect even when that QuestID was already Sourced  
    * Added a Debug WARN log for when a SpellEffect QuestID is listed in Unsorted but will also be directly linked to the Item/group  
    * Added a Debug INFO log for when a SpellEffect QuestID is not added to the trigger group since the Quest is already Sourced  
- [DB] Commented out a bunch of HQTs which are now directly incorporated onto their corresponding Achievement Criteria  
- [Parser] Various updates for Criteria automation/Sourcing checks  
    * SOURCED is now a collection of HashSets so that adding the same group at multiple stages of the parse no longer creates multiple copies of the data  
    * Debug Warning for Unsorted content which is Sourced has been simplified  
    * SOURCED now includes Unsorted content which is actually added by Contribs (We simply check for \_unsorted if we wish to exclude Unsorted data for certain operations)  
    * Error for 'Referenced Source Quest' not Sourced now uses SOURCED for better accuracy (ideally we will also exclude \_unsorted in the future but for now some sourceQuests link to HQTs)  
    * Criteria which are linked to a single, unsorted QuestID will now inherit that QuestID themselves (this will require various HQTs removed from HQT sections to remove duped questIDs at this time)  
- Update LoU Trash Lieutenant HQTs  
- Siege of Boralus is broken too. Blizzard forgot to return the horde-only boss.  
- [DB] Added a coord for Lost Vault (maybe will just ignore tho)  
- [Parser] Future fix for coords being shifted when they shouldn't be due to timeline  
- The MOTHERLODE heroic any mythic appearances are still obtainable through weekly vault in TWW season 2.  
- Classic: Fixed the Auction House Module - it should no longer freeze WoW when you close it sometimes... maybe. Please let me know otherwise.  
- Fix some reported errors  
- [DB] Fixed some inaccurate objectives  
    [Parser] Fixed some warnings for Retail parse  
- [Parser] Objective 'cost' now merges into the parent data when not parsing with objectives  
- [DB] Fixed an objective for 'Overseeing and You: Making the Right Choices'  
- Update LoU trash lieutenant HQTs  
- [Parser] When ignoring Objective data in Parse (Retail) the objective data is now converted into the parent quest automatically [WIP]  
- [DB] Fixed an objective provider for Attuned Frog  
- [Logic] More ignored Objects & removed old comments  
- [DB] Fixes awkward mapping in Cata Classic  
- MOTHERLODE heroic and mythic sources are removed this season.  
    Added timelines to BfA dungeons.  
- [Logic] Simplified CURRENT\_EXPANSION assignment  
- Added few more NYI raid pieces from 11.0.0.  
- [Logic] Get Expansion by in-game API.  
    Use GetServerExpansionLevel to get current expansion.  
- [Parser] PostProcessing stage should be much faster now due to improved Ensemble cleanup logic  
- [Parser] Fixed some unintended quests getting back into Unsorted  
    [DB] Fixed a removed JC recipe showing in Unsorted  
    [DB] Some duplicate questIDs cleaned up  
- [Parser] Fixed an issue where Sourced Things whose type was being assigned during consolidation could still be put into Unsorted Quests  
- [Logic] Object listings now attempt to use a fallback display Icon from their contained Item/Criteria listings if the Object itself has no custom Icon  
- [DB] Single object provider QI sorted  
