# AllTheThings

## [DF-3.8.5](https://github.com/DFortun81/AllTheThings/tree/DF-3.8.5) (2023-12-01)
[Full Changelog](https://github.com/DFortun81/AllTheThings/compare/DF-3.8.4...DF-3.8.5) [Previous Releases](https://github.com/DFortun81/AllTheThings/releases)

- finished trading post + parser  
- A couple more missing objects.  
- SOD: Added some Paladin Runes.  
- Appearances and Achievements can be added to Blizzard Tracking UI by ALT-click  
- Character-specific Battle Pets (Guild Herald/Guild Page) now have Account-Wide handling (if there are others please let me know)  
    Couple Unsorted Items  
- Guild Rep Requirement  
- Removed custom SourceFinder window logic and related object creator (superceded by /att list)  
- added class items  
    added monthly reward  
    todo: had petID  
    add 2 missing items  
    harvest  
- SOD: Added Chest Engraving spells.  
- Classic: Inscription now tagged with Wrath Phase 1.  
- some work on trading post items  
    2 items missing (no item id)  
    class set items missing ( 8 items instead of 6)  
    harvest missing due previous 2 things to do  
- gift of arthas itemtooltip updated as its back  
- Doti update.  
- Classic: Greater Drums of War doesn't appear to be in the game anymore with Wrath Classic.  
- Wrath Classic: The quest "Stormers and Rumblers" is still available until Cataclysm.  
- Wrath Classic: Tablet of Grace of Air Totem III is no longer usable.  
- Avatar of Flame no longer shows up on Classic Era.  
- Classic: Fixed an issue involving race specific data in dynamic categories.  
- Classic: C\_ToyBox might exist, but it isn't used. Good job Blizzard.  
- Fixed a number of profession issues caused by certain tables not persisting their data.  
- Classic: Heirlooms no longer appear as an option pre-Wrath Classic.  
- Classic: Faction reputation tooltips no longer produce an error when looking at the opposite faction's tooltip.  
- Classic: RecipeDB no longer misbehaves and unflags specific recipe associations.  
- added gift of arthas (recipeId later)  
- Classic: Fixed a bug with account wide tracking for Battle Pets and Mounts in Classic Era caused by the presence of the wrong API. (Thanks Blizzard)  
- Northend racing meta IDs  
- Parser fix  
- Adjusted the _noautomation check on Achievements so they are still duplicated under Achievements  
- PVP Brawl HQT  
- Classic: Now ignoring the "new" battle pet APIs before Wrath.  
- Dream Wardens Renown Quests  
    Reported Errors  
- Doti update.  
- added 3 trading post items  
- Map Exploration can now be manually triggered with a refresh.  
- Consolidated The Superbloom a bit  
    Recycling Requisitions in Mechagon are not Character Unlocks...  
- Update Quests.lua  
- SoA Fixes  
    Fixed the other "outstanding" quests that I had showing up on my main character.  
- Parser wasn't tagging PvP based on PvP costs properly  
- Update Quests.lua  
- Latest Tyr Quest  
- renamed months so they are sorted by date  
- note for promos  
    removed previously added timeline  
- tabard of fury はい  
- Fixed 'The Grandmaster's Voucher' properly  
- Don't consider 'The Grandmaster's Voucher' a Character Unlock (parser might complain)  
- Re-added the old versions of removed Items which people still have in their bags  
- Added some missing objects to Sunken Temple.  
- Modifying crit to allow grouped content. (required for Defense Protocol drops)  
- Typos (tsk tsk)  
    Couple fixes  
    S3 Explorer/Adventurer catalyst tier pieces no longer show to upgrade (they don't change from LFR)  
    Achievement Category groups are treated the same as Filter/Header groups for sorting  
- Update Quests.lua  
- Reparsed with Achievement/Criteria re-work  
- Parser Achievement/Criteria re-work (#1527)  
    * Adjusted Achievement harvest to provide better data formats for new Parser logic
  
    * Added some CSV support to Parser
  
    Moved a lot of Processing/Merge code for easier maintenance
  
    Parser now merges the 'cost' field correctly
  
    Parser Cost Logic now entirely encapsulated within a custom Type to simplify everything
  
    TryConvert now has a lazy mode for improved performance where simple type casting is enough
  
    Achievements/Criteria now can do a huge amount of automation from in-game AchievementDB and WagoDB
  
    * CriteriaUID is used where possible
  
    * Nested Criteria via CriteriaTree is now used to determine Criteria for Achievements
  
    * Achievements/Criteria now incorporate more DB data, and will remove the 'achievement\_criteria' symlink if possible
  
    * Many more Criteria now use _quests and _npcs to move themselves into the respective group which grants the Criteria
  
    * Criteria with _npcs which fail to move will revert into a simple 'crs' list instead
  
    * Criteria (which are not ignored by Blizzard) with available Item data will be linked with an Item provider (if the Criteria is not being incorporated, then the provider will be applied to the Achievement)
  
    * Achievements will only incorporate DB data when nested under a 'header' group or another Achievement
  
    * Achievements with a single Criteria will not incorporate that Criteria
  
    * Unsorted groups (i.e. /att unsorted) will not incorporate DB data
  
    * Known Issue: Instance Difficulty is not properly accounted for when moving Criteria for instance-related encounters
  
    * Ignore some JC criteria in Retail which are automatic
  
    * Ignore incorporating Criteria data for Criteria which already use _encounters
  
    * Achievement/Criteria data cannot be incorporated into Classic builds (becuase it has different data per ID, because of course)
  
    * Cursed Game Hunter converted to criteriaUIDs thanks to glorious new achievement technology
  
    * More Achievement Criteria stuff, including ModifierTree incorporation
  
    All sub-nested Criteria which are 'useful' should be nested under the Achievement
  
    Any base Criteria which has no nested sub-criteria will re-create the original index-based Criteria and warn in logging with how to fix
  
    (I haven't tested this at all in game, maybe it's horrible)
  
    * More Criteria adjustments mebe is gooder
  
    * Automatically generated Achievement Criteria now have proper faction-tag from Blizzard data (since non-Faction based Achievements can have Faction-based Criteria)
  
    * Solved achievement 13635 weirdness
  
    * It works but it looks stupid so maybe it is actually stupid?
  
    * Don't try to merge criteria which require Achievements (those are typically meta\_achievement anyway)
  
    * Added another warning for Myrhial to deal with/figure out ;)
  
    * Fixed the criteria warning and realized there were only two actual places to fix :laughing:
  
    * Nested Criteria now inherit their proper root Criteria name
  
    Debug Achievement DB output nests Criteria properly
  
    * Some other criteria warnings added/adjusted
  
    Fallback root criteria is now added automatically if nested criteria fails completely to be incorporated with useful data
  
    * Yeet
  
    * Cyphers of the First Ones can has some _noautomation, as a treat
  
    * Few more Parser updates and old code clean up
  
    * Sourced a couple Factions which nest Criteria
  
    Commented out some no-longer-needed Retail Criterias
  
    * _noautomation works on Achievements
  
    Some Criteria are allowed to nest under Achievements again
  
    Some Legion Class hall achievement adjustments for clarity
  
    * meta\_achievement sym so parser is happy again
  
    * Achievement 1206 now uses modern criteriaUID in the retail era
  
    * Adjusted 'To All The Squirrels I've Loved Before' a bit more so each nested Criteria has proper data in Retail
  
    * Moved some 'providers' processing into Consolidation phase
  
    ---------
  
    Co-authored-by: Myrhial <8618272+ninaarens@users.noreply.github.com>  
- Redridge Mountains - extended descriptions for drops from phased mob as requested by Gold.  
- Classic: Reparsed DB.  
- Retail Errors  
    Added some info for Pandaland achieve  
- removed some outcommented stuff  
- Some Sorting  
- -- Some More Doti  
    -- Added NYI Stuff into TP, also rearrange it  
    -- Some Unsorted Cleaning ongoing. (Test from MissingItems upcoming selection)  
