# AllTheThings

## [SL-2.9.6-24-g95feddd](https://github.com/DFortun81/AllTheThings/tree/95fedddc02a810ada4cd30320481a747b190c871) (2022-09-15)
[Full Changelog](https://github.com/DFortun81/AllTheThings/compare/SL-2.9.6...95fedddc02a810ada4cd30320481a747b190c871) [Previous Releases](https://github.com/DFortun81/AllTheThings/releases)

- Another quick pass of relatively simple #errors  
- Removed some redudant 'select(1,x)' usage  
- cata classic, mop classic & wod classic structure added, cuz why not  
- clarifying ce's with using a slightly different icon  
- updated tbc deluxe edition, achievement for blizzcon & added wotlk classic upgrades  
- doing the easy way of adding the mount. shadowlands classic crieve can fix it  
- the frostblood does not show up yet tho, as the api is shy?  
- bump to 9.2.7.45338  
    added Frostbrood Proto-Wyrm  
- fixed bfa s4 elite to have them marked as removed. updated bfa essences from m+  
- A whole bunch more #rrors and stuff  
- Furthered the Parser feedback for other fields expecting a single numeric value  
- Made Parser have better error when 'qg' or 'cr' field has bad value  
- Few more quick #errors  
    Some bad map names  
- Minor adjustment to TF Bindings since they have old data in the ItemDB  
- Prof  
- TF bindings also not restricted by class technically  
- Smashed through a bunch of #errors (didn't get to fully verify all of them in game because the login servers got borked)  
- Reverted containsAny function back to expect only two arrays and added a special function only for symlink processing of variable argument contains instead  
- Performance improvment to cost calculations due to having not seen specific debug message in quite some time... (inb4 someone reports a bad cost showing up within 5 hours of Git commit due to this)  
- Fixed some removed TotC items which lost their appearances due to being moved inside the Instance  
    Fixed various symlinks which attempted to perform further processing on results from subroutines, as the subroutines are now automatically finalized, they have to be merged back for further processing  
    Fixed achievement criteria type which got lost in merge with symlinks at some point  
- Symlink Adjustments (#1101)  
    * containsAny function now supports a set of individual values as well as the previous table comparison
  
    * 'postprocess' is an obsolete symlink command due to the finalization of the symlink always accounting for duplicate content in the result set
  
    * Partial fix for a stand-alone ATT window for a Group which uses a 'selectparent' symlink command if there is only one Source of that Group in ATT
  
    * Cleaned up logic for 'selectparent' a bit
  
    * Further conversion of various symlink command processes
  
    * Removed a few redundant uses of the 'merge' command
  
    * Cleaned up an Oribos symlink to be slightly more efficient
  
    Revision and clean up of further symlink logic/commands
  
    * Converted the last non-subroutine symlink
  
    * Simplified some PvP Ensemble common symlink subroutines using 'extract' (since they were actually broken due to how many ensembles are currently sourced)
  
    Partially updated 'sub' command for symlinks
  
    * Some missed constants
  
    * Converted one subroutine to test functionality
  
    * Finished migration of symlink commands to new format
  
    Adjusted symlink command parameters to include the 'finalized' set to make it cleaner overall
  
    * Converted more subroutines
  
    Fixed logic where successive subroutines were acting upon results from previous subroutines (previously logic caused subroutine results to be determined and appended separately, now they are finalized after being determined)
  
    * Further subroutine re-work
  
    'subif' command is actually pointless with logic conversion since it was only ever used internally to choose a subroutine based on the object info
  
    * Fixed the way modID was being applied via symlinks since we don't want to alter the Source data
  
    Rearranged logic for finishing up a symlink command such that the proper set of final results are cached
  
    Cached lookups of symlink results are now the proper set of adjusted results (i.e. previously things like Azerite caches could change the shown results between tooltips due to the cached symlink results being slightly different than the first symlink results)
  
    * Fixed a Relinquished Relic command
  
    * Fixed 'merge' command not clearing the finalized results which moved back into the search result set
  
    Converted Legion relinquished subroutines
  
    * Converted "Legion Relinquished Base" subroutine, and drastically improved the performance by using 'extract'
  
    Removed references to old subroutine table
  
    * Cleaned up comments for subroutines
  
    * Fixed a 'where' command using capital 'Where'
  
    * Fixed a small issue where tooltips could think they were actually inside an ATT window and thus fail to render Contains information under some circumstances (i.e. completing 'A New Deal' then checking Honor tooltip)
  
    Added a recursive function to ensure only following direct parent relationships (not sure if changing the existing function to use rawget would break some functionality)  
- Added timeline data to the DK starting area.  
- Updated the icon used by the Scarlet Enclave for it to appear in Wrath Classic.  
- Enable autochangelog  