# AllTheThings

## [SL-2.7.12-21-g62999fc](https://github.com/DFortun81/AllTheThings/tree/62999fc2cf838ec8688fba7d55f2a48672ea7274) (2022-05-20)
[Full Changelog](https://github.com/DFortun81/AllTheThings/compare/SL-2.7.12...62999fc2cf838ec8688fba7d55f2a48672ea7274) [Previous Releases](https://github.com/DFortun81/AllTheThings/releases)

- Added Lockpicking skill to Parser so it stops complaining, since Item Harvest now picks that skill up in-game  
- Objects with Quests now support lock criteria  
    Couple #errors  
    Updated data for 'Whispers of N'Zoth' since it seems to be drastically different than when previously implemented  
    Couple other fixes for some Parser output  
- Adjusted logic for checking a sub-item listed within a Recipe tooltip since I forgot Blizzard likes to make Recipes which don't actually match the Item they craft  
    Finally got a full, successful re-harvest of in-game Items (using Tourney realm for extra dataz)  
    Reparsed with many fixed Items (Recipes with invalid Class assignments, Armor missing Faction/Class assignments, etc.)  
- Fixed a stuck-condition when the sub-item of a Recipe fails to load  
    Tried to add some logic to remove fully-harvested partitions but decided it's not really that important  
- Fixed a bug with Item Harvesting when an Item specifies 'Races' which ATT doesn't know about  
    Fixed an issue where harvested Recipes which include a hyphen would incorporate the crafted item information into the Recipe itself (i.e. Technique: Glyph of Shadow-Enemies)  
    Fixed an issue where harvesting items that contained a sub-item would skip the sub-item due to unloaded item data  
- Fixed some invalid objectives. Items you can collect without being on a quest use cost, not objective. Items received when accepting a quest when not used to satisfy an objective are listed in providers.  
- Added the capability of marking a quest as 'unknown' as to Party Sync status so the user will see it with Locked Quests enabled but have a tooltip message about Party Sync not being confirmed yet  
    Cleaned up a lot of incorrect 'cost' usage in Ghostlands quests  
    Couple #errors  
- Removed duplicate HQT file  
    Various clean up  
    Various #errors  
- In TBC Classic Soryn on the Isle of Quel'Danas actually sells Vengeful Gladiator's gear, not Merc.  
- Synced the 'locked' logic for Items which have their own QuestID (fixes #999)  
- Major consolidation / reorganization of BFA N'Zoth Assaults  
- Added timeline information for Striped Dawnsaber.  
- Updated Old School Ride and associated mounts / quests.  
- Sync locales  
- Smith Hauthaa is not available until the Anvil is available.  
- Bump CI deps  
- Popout windows for 'Common Boss Drop' groups will now show Sources for that specific group (if any) to help track completion of possible Sources for a Thing that is a common drop from multiple Rares or other trackable content  
    Fixed creature Sources in popout 'Source(s)' header  
    Revised some 'Title' fields such that they properly sort by the visible text in ATT windows  
- Small adjustments  
- crs tag  
- Huge revamp to 'cost' calculations (#1002)  
    * Huge revamp to 'cost' calculations:
  
    * CostCollectibles for cost items are now calculated into the cache for the respective Thing when referenced
  
    * Revised logic of determining cost groups when filling groups
  
    * CollectibleAsCost and CollectedAsCost are now common functions shared between Type libraries
  
    * Filling groups will now prevent duplicate listings of a Currency group
  
    * Added a bit of Update-time-checking logic for auto-updated groups with a 'cost' to prevent some infinite looping when attempting to calculate if a group is collectible when it contains nothing currently collectible (perhaps can expand on this further in the future to reduce repeated update calls when nothing has changed regarding Filter logic or character changes)
  
    * Main list progress no longer fluctuates on each refresh due to cost re-calculations
  
    * Cost Items which have already been fully utilized for all Cost Collectibles are no longer considered Collectible, but continue to show their contained Collectibles when filled in popout/minilist or Tooltips (This means collectibles from 'costs' are slightly more valuable to your overall progress since the Total will decrease while the Progress increases)
  
    Search groups clear their parent reference prior to doing fill calculations to ensure accuracy of filtering for filled groups
  
    * Define CollectibleAsQuest prior to Type use to fix directly using the function
  
    * Revised logic for calculating amount required for collectibles to account for Containers as well
  
    Revised wording of currency calcuation texts
  
    * Cleaned up use of data for generation of tooltip progress to make it cleaner and easier to understand
  
    * Reduced function layer
  
    * Reverted wrong Icon function used
  
    * Further refinement of some cost logic performance  
- Wrong variable used when creating tooltip callback for Achievement Criteria data (fixes #1005)  
